Skip to content

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 5 | Prep Exercises #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HassanOHOsman wants to merge 97 commits into
base: main
Choose a base branch
from
Open

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 5 | Prep Exercises #293

HassanOHOsman wants to merge 97 commits into from

Conversation

@HassanOHOsman
Copy link

@HassanOHOsman HassanOHOsman commented Dec 8, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

This PR contains my solutions to all the "Prep Exercises" in Sprint 5 of the "Tools" module.

@HassanOHOsman
create a dir for my exercises and a .py file for exercise 1
d7860a4
@HassanOHOsman
provide 2 solutions to exercise 1
c6edd33
@HassanOHOsman
rename file
bbca608
@HassanOHOsman
create file to exercise 1
597f47e
@HassanOHOsman
add exercise 1 question
adec5ea
@HassanOHOsman
answer to Q 1 of exercises
c202adf
@HassanOHOsman
create venv
4917fe7
@HassanOHOsman
install mypy
ab0e5d5
@HassanOHOsman
create a test file to test some py code
b0143fd
@HassanOHOsman
adding type annotation to the function def to avoid getting errors wh…
5c7d52c 
…en running mypy
@HassanOHOsman
re-add type annotation to function def
6803aed
@HassanOHOsman
delete the test file
dd86ef8
@HassanOHOsman
create a .py file for exercise 3
9df4222
@HassanOHOsman
type annotate open_account function return
bf4f92c
@HassanOHOsman
type anno. open_account arguments
0b58dee
@HassanOHOsman
add a return line to function open-account
e133ed6
@HassanOHOsman
type anno. return for function sum_balance
0692d80
@HassanOHOsman
type anno. the argument accounts of function sum_balances
93e8215
@HassanOHOsman
type annotate the argument and return for function format_pence_as_st…
eaa2fa4 
…ring
@HassanOHOsman
adding the missing third argument: "balances" to the 2 open_account f…
b7f3ae2 
…unction calls
@HassanOHOsman
updated all the int values to float
530b650
@HassanOHOsman
updating type anno. and making a few changes
b55e70c
@HassanOHOsman
correcting syntax error in sum_balances func and the name of the 1st …
ccce3db 
…argument in open_account
@HassanOHOsman
fixed bugs in the 2 open_account fuc calls at the bottom
bb87b72
@HassanOHOsman
corrected the name bug for the format_pence_as_string call at the bottom
ce70769
@HassanOHOsman
create .py file for exercise 4
a70ac33
@HassanOHOsman
add solution to problem 4
550f320
@HassanOHOsman
create .py file for exercise 5
ee4aae2
@HassanOHOsman
add a question to problem 5
dc9fa85
@HassanOHOsman
create a new function as per exercise 5 requirments
23cf5c5
@HassanOHOsman HassanOHOsman added 📅 Sprint 5 Assigned during Week 5 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 8, 2025
@LonMcGregor
Copy link

LonMcGregor commented Jan 14, 2026

There are a lot of files comitted here, can you take a look and figure out why that is happening?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 14, 2026
@HassanOHOsman
Copy link
Author

HassanOHOsman commented Jan 14, 2026

There are a lot of files comitted here, can you take a look and figure out why that is happening?

Yes, I just ignored the .venv so that it's easy for you to navigate through. Please let me know if you need anything else :)

@HassanOHOsman HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 14, 2026
LonMcGregor
LonMcGregor reviewed Jan 19, 2026
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on these tasks, there are just two of them I have suggestions for improvements in

prep-exercises/exercise_nine.py Outdated
def print_family_tree(person: Person) -> None:
print(person.name)
for child in person.children:
print(f"- {child.name} ({child.age})")
Copy link

@LonMcGregor LonMcGregor Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This correctly prints out this person's children. Do you think there is a way to make it print out the whole family tree?

(hint: recursion)

Copy link
Author

@HassanOHOsman HassanOHOsman Jan 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
The current code actually does print the whole family tree (the parent: Imran and the 2 children Fatima & Aisha as per my examples). I've attached a screenshot. Nevertheless, if you still think it's better to be done through the recursion approach please let me know. Thank you! :)
Screenshot 2026-01-21 at 23 31 36

Copy link

@LonMcGregor LonMcGregor Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this task so far. I was thinking about if, for example in that screenshot, if Aisha had a child as well (i.e. Imran's grandchild). Could you design the function in such a way that it could print that out as well? Recursion might help here.

Copy link
Author

@HassanOHOsman HassanOHOsman Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now understand. Thank you for clarifying. Done as instructed. Please review and let me know if there's anything else that needs improving. I appreciate you help :)

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 19, 2026
@HassanOHOsman HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 21, 2026
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 26, 2026
@HassanOHOsman HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 5 Assigned during Week 5 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HassanOHOsman @LonMcGregor